Fix controller cleanup issues
All checks were successful
Tests / Laravel tests (pull_request) Successful in 3m24s
All checks were successful
Tests / Laravel tests (pull_request) Successful in 3m24s
This commit is contained in:
@@ -41,7 +41,7 @@ test('the homepage shows the public cv data', function () {
|
||||
->assertViewHas('personalia', fn ($personalia) => $personalia->contains($personalium))
|
||||
->assertViewHas('education', fn ($educations) => $educations->contains($education))
|
||||
->assertViewHas('experience', fn ($experiences) => $experiences->contains($experience));
|
||||
})->skip('Homepage currently depends on missing public/storage/sitiweb.svg.');
|
||||
});
|
||||
|
||||
test('a hidden personalia value can be requested and the click is queued for notification', function () {
|
||||
Queue::fake();
|
||||
|
||||
@@ -88,11 +88,12 @@ test('an authenticated user can update personalia', function () {
|
||||
->assertSessionHasNoErrors()
|
||||
->assertRedirect(route('personalia.index'));
|
||||
|
||||
expect($personalium->refresh())
|
||||
->value->toBe('new@example.com')
|
||||
->hidden->toBeFalse()
|
||||
->icon->toBe('fa-regular fa-envelope');
|
||||
})->skip('PersonaliaController::update currently uses Request instead of PersonaliaRequest.');
|
||||
$personalium->refresh();
|
||||
|
||||
expect($personalium->value)->toBe('new@example.com');
|
||||
expect($personalium->hidden)->toBeFalse();
|
||||
expect($personalium->icon)->toBe('fa-regular fa-envelope');
|
||||
});
|
||||
|
||||
test('an authenticated user can delete personalia', function () {
|
||||
$user = User::factory()->create();
|
||||
@@ -104,4 +105,4 @@ test('an authenticated user can delete personalia', function () {
|
||||
->assertRedirect(route('personalia.index'));
|
||||
|
||||
$this->assertDatabaseMissing('personalia', ['id' => $personalium->id]);
|
||||
})->skip('PersonaliaController::destroy currently does not match the resource route parameter binding.');
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user