roberto/cv-roberto
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor controllers to use form requests for validation

Browse Source
This commit is contained in:
Roberto Guagliardo
2025-07-23 20:41:26 +02:00
parent 724c89c727
commit 9cce21d080
12 changed files with 201 additions and 131 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
app/Http/Controllers/SkillController.php
View File

@@ -4,43 +4,25 @@ namespace App\Http\Controllers;
use App\Models\Skill;
use Illuminate\Http\Request;
use App\Http\Requests\SkillRequest;
class SkillController extends Controller
{
/**
* Display a listing of the resource.
*/
public function index()
{
$skills = Skill::latest()->get();
return view('skills.index', compact('skills'));
}
/**
* Show the form for creating a new resource.
*/
public function create()
{
return view('skills.create');
}
/**
* Store a newly created resource in storage.
*/
public function store(Request $request)
public function store(SkillRequest $request)
{
$validated = $request->validate([
'title' => 'required|string|max:255',
'description' => 'nullable|string',
'rating' => 'required|numeric|min:1|max:10',
'image' => 'nullable|image|max:2048',
'type' => 'required|in:rating,tag,other',
]);
$skill = Skill::create($validated);
$skill = Skill::create($request->validated());
if ($request->hasFile('image')) {
$skill->addMediaFromRequest('image')->toMediaCollection('image', 'public');
@@ -49,37 +31,19 @@ class SkillController extends Controller
return redirect()->route('skills.index')->with('success', 'Vaardigheid toegevoegd.');
}
/**
* Display the specified resource.
*/
public function show(Skill $skill)
{
return view('skills.show', compact('skill'));
}
/**
* Show the form for editing the specified resource.
*/
public function edit(Skill $skill)
{
return view('skills.edit', compact('skill'));
}
/**
* Update the specified resource in storage.
*/
public function update(Request $request, Skill $skill)
public function update(SkillRequest $request, Skill $skill)
{
$validated = $request->validate([
'title' => 'required|string|max:255',
'description' => 'nullable|string',
'rating' => 'required|numeric|min:1|max:10',
'image' => 'nullable|image|max:2048',
'type' => 'required|in:rating,tag,other',
]);
$skill->update($validated);
$skill->update($request->validated());
if ($request->hasFile('image')) {
$skill->clearMediaCollection('image');
@@ -89,9 +53,6 @@ class SkillController extends Controller
return redirect()->route('skills.index')->with('success', 'Vaardigheid bijgewerkt.');
}
/**
* Remove the specified resource from storage.
*/
public function destroy(Skill $skill)
{
$skill->clearMediaCollection('image');